From 84fb44475f0dbd7d01d980a634432cff1bb37638 Mon Sep 17 00:00:00 2001 From: yugecin Date: Thu, 19 Jan 2017 19:55:25 +0100 Subject: [PATCH] fix array index oob exception when changing dropdown option (fixes #118) --- src/yugecin/opsudance/ui/OptionsOverlay.java | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/yugecin/opsudance/ui/OptionsOverlay.java b/src/yugecin/opsudance/ui/OptionsOverlay.java index 70e607ac..0aae9e08 100644 --- a/src/yugecin/opsudance/ui/OptionsOverlay.java +++ b/src/yugecin/opsudance/ui/OptionsOverlay.java @@ -30,7 +30,6 @@ import itdelatrisu.opsu.ui.MenuButton; import itdelatrisu.opsu.ui.UI; import org.newdawn.slick.*; import yugecin.opsudance.core.DisplayContainer; -import yugecin.opsudance.core.state.ComplexOpsuState; import yugecin.opsudance.core.state.OverlayOpsuState; public class OptionsOverlay extends OverlayOpsuState { @@ -402,9 +401,11 @@ public class OptionsOverlay extends OverlayOpsuState { if (isListOptionOpen) { if (y > optionStartY && listStartX <= x && x < listStartX + listWidth && listStartY <= y && y < listStartY + listHeight) { - hoverOption.clickListItem(listHoverIndex); - if (listener != null) { - listener.onSaveOption(hoverOption); + if (0 <= listHoverIndex && listHoverIndex < hoverOption.getListItems().length) { + hoverOption.clickListItem(listHoverIndex); + if (listener != null) { + listener.onSaveOption(hoverOption); + } } SoundController.playSound(SoundEffect.MENUCLICK); }